This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19418 ) Change subject: pcuif_proto: version 0xa: add support for NSVC IPv6 support ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/19418/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/19418/1//COMMIT_MSG@11 PS1, Line 11: IPPROTO_IPIP is used for IPv4, IPPROTO_IPV6 for IPv6. 0 means unset or > This doesn't make sense to me, you are using something from the wrong layer afaiu. […] Yes, it's for a different layer. But I didn't want to invent new enums etc if there are good known values. So I found the IPPROTO which suites the case. https://gerrit.osmocom.org/c/osmo-bts/+/19418/1/include/osmo-bts/pcuif_proto.h File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/19418/1/include/osmo-bts/pcuif_proto.h@160 PS1, Line 160: * OS dependent. IPIP => v4, IPV6 => v6, 0 => unused */ > So what? it goes over unix sockets, so same host/system on both sides... Maybe it still goes over an unix socket. But if we move further around I like to have well defined values. I looked for a more specified value and found the IPPROTO values. https://gerrit.osmocom.org/c/osmo-bts/+/19418/1/include/osmo-bts/pcuif_proto.h@163 PS1, Line 163: struct in_addr ipv4; > simply call the fields v4 and v6? So you have remote_ip.v6 ... Same as we do in in46_addr in libgtp. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4067b1af041b2cdad60d6fb16c9caee98bc218dd Gerrit-Change-Number: 19418 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2020 14:12:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200728/8e1172ad/attachment.htm>