Change in libosmocore[master]: Gb/BSSGP: replace hardcoded Tx into NS library by a callback

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 28 13:16:46 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19414 )

Change subject: Gb/BSSGP: replace hardcoded Tx into NS library by a callback
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/19414/4/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/19414/4/include/osmocom/gprs/gprs_bssgp.h@15 
PS4, Line 15: typedef int bssgp_bvc_send(void *ctx, struct msgb *msg);
Usually one uses:
typedef int (*bssgp_bvc_send)(void *ctx, struct msgb *msg);
Then:
void bssgp_set_bssgp_callback(bssgp_bvc_send ns_send, void *data);


https://gerrit.osmocom.org/c/libosmocore/+/19414/4/src/gb/gprs_bssgp.c 
File src/gb/gprs_bssgp.c:

https://gerrit.osmocom.org/c/libosmocore/+/19414/4/src/gb/gprs_bssgp.c@76 
PS4, Line 76: /* callback to be compatible with users which do not set the bssgp_ns_send function */
to be backward-compatible with old users



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
Gerrit-Change-Number: 19414
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Jul 2020 13:16:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200728/7701389e/attachment.htm>


More information about the gerrit-log mailing list