Change in osmo-bts[master]: vty: Allow setting power-ramp max-initial to negative values

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jul 27 11:11:09 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/19406 )


Change subject: vty: Allow setting power-ramp max-initial to negative values
......................................................................

vty: Allow setting power-ramp max-initial to negative values

This allows for instance ramping up from -10 dBm -> -4 dBm if NOMTXPOWER
of SDR is really low (below 0dBm) or because the max_power_red is >=
NOMTXPOWER.

Related: SYS#4920
Change-Id: I0f27fb7b86b58c5a80f5342b66ff4f5d1b775498
---
M src/common/tx_power.c
M src/common/vty.c
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/06/19406/1

diff --git a/src/common/tx_power.c b/src/common/tx_power.c
index 8f50b0f..93aec7d 100644
--- a/src/common/tx_power.c
+++ b/src/common/tx_power.c
@@ -268,8 +268,8 @@
 	if (we_are_ramping_up(trx)) {
 		if (tpp->p_total_tgt_mdBm <= tpp->ramp.max_initial_pout_mdBm) {
 			LOGPTRX(trx, DL1C, LOGL_INFO,
-				"target_power(%d) is below max.initial power\n",
-				tpp->p_total_tgt_mdBm);
+				"target_power (%d mdBm) is below or equal to 'power ramp max-initial' power (%d mDbm)\n",
+				tpp->p_total_tgt_mdBm, tpp->ramp.max_initial_pout_mdBm);
 			/* new setting is below the maximum initial output
 			 * power, so we can directly jump to this level */
 			tpp->p_total_cur_mdBm = tpp->p_total_tgt_mdBm;
diff --git a/src/common/vty.c b/src/common/vty.c
index 91f3706..3f24d66 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -723,7 +723,7 @@
 
 #define PR_STR "Power-Ramp settings\n"
 DEFUN(cfg_trx_pr_max_initial, cfg_trx_pr_max_initial_cmd,
-	"power-ramp max-initial <0-100000> (dBm|mdBm)",
+	"power-ramp max-initial <-10000-100000> (dBm|mdBm)",
 	PR_STR "Maximum initial power\n"
 	"Value\n" DB_MDB_STR)
 {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19406
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0f27fb7b86b58c5a80f5342b66ff4f5d1b775498
Gerrit-Change-Number: 19406
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200727/8c683a5e/attachment.htm>


More information about the gerrit-log mailing list