Change in osmo-ttcn3-hacks[master]: library/RLCMAC_CSN1_Types: fix byte/bit order in GprsMobileAllication

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 23 08:20:56 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19342 )

Change subject: library/RLCMAC_CSN1_Types: fix byte/bit order in GprsMobileAllication
......................................................................


Patch Set 3: Code-Review+1

Why not simply handling it the way it is supposed to be sent on the wire? I see no reason for managing it differently in ttcn3 than when sending it on the wire. It's just a bitstring.

I'm not against this patch, simply asking myself about the implications. Is it because it's easier to manage in TTCN3 when writing tests?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19342
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8f2c8c7b234605523a4fd518210b45ea3c088ff6
Gerrit-Change-Number: 19342
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Jul 2020 08:20:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200723/3586e736/attachment.htm>


More information about the gerrit-log mailing list