Change in osmo-bts[master]: bts-trx: Use bool type for on/off state variables

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jul 22 18:07:57 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19365 )

Change subject: bts-trx: Use bool type for on/off state variables
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/19365/2/src/osmo-bts-trx/l1_if.h 
File src/osmo-bts-trx/l1_if.h:

https://gerrit.osmocom.org/c/osmo-bts/+/19365/2/src/osmo-bts-trx/l1_if.h@68 
PS2, Line 68: arfcn_valid
It feels like a bitmask could be used here, or rather two:

  uint32_t param_valid;
  uint32_t param_sent;

instead of these separate variables, but this is just an idea.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19365
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icb1b7bd8852417ab7b9a7dbc205aa6f6db97d64d
Gerrit-Change-Number: 19365
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Jul 2020 18:07:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200722/bd70a503/attachment.htm>


More information about the gerrit-log mailing list