Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_si_acc_rotate

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jul 21 18:47:23 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19359 )

Change subject: bsc: Introduce test TC_si_acc_rotate
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19359/1/bsc/BSC_Tests.ttcn 
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19359/1/bsc/BSC_Tests.ttcn@1857 
PS1, Line 1857: runs on test_CT
This is not really needed here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19359/1/bsc/BSC_Tests.ttcn@1886 
PS1, Line 1886: alt
An 'alt' statement with only one alternative? This looks like our president elections with only one possible candidate :D I think you can unwrap this receive statement, or add more alternatives is that was planned.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19359/1/bsc/BSC_Tests.ttcn@1923 
PS1, Line 1923: "ACC", j, " ERROR: allowed ", times_allowed[j], " < 1 times"
Shouldn't this message be a part of setverdict() statement?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19359
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I18d0243353fce547d126d62c34415628a21cb52b
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Jul 2020 18:47:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200721/a8919c84/attachment.htm>


More information about the gerrit-log mailing list