Change in osmo-bsc[master]: Introduce support for ACC subset rotation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 21 16:27:46 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19303 )

Change subject: Introduce support for ACC subset rotation
......................................................................


Patch Set 3:

(1 comment)

Thanks for the review, I'll update the .adoc file suggestions and re-submit.

https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/include/osmocom/bsc/acc.h 
File include/osmocom/bsc/acc.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/include/osmocom/bsc/acc.h@38 
PS3, Line 38: len_allowed_adm
> qty / quantity / count would be more obvious than 'len', IMHO. But only change if you agree. […]
TBH I thought a lot about using "size" or "length" terms. "size" because we talk about creating sets/subsets, so one can speak about "set sizes". Otherwise as "length" since one can usually think or imagine of it as a list of ACC numbers (again, as a usual representation of a list or set).
So all in all, I have no big preference and I just picked one, but I think any of them terms can be used interchangeably.
For that reason I think keeping it as it is to avoid spending time on this, but if someone really thinks another term is better I can change all references.

In this struct I use "length" here when I use the param as a parameter used to generate the sets, while I use "count" where the variable is really holding a count, that is, counting whatever from an already generated set.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I952c9eeae02809c7184078c655574ec817902e06
Gerrit-Change-Number: 19303
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 21 Jul 2020 16:27:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200721/c9b36669/attachment.htm>


More information about the gerrit-log mailing list