Change in libosmocore[master]: pkg-config: Use "Requires" for external libs such as talloc.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 21 13:46:42 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/19358 )


Change subject: pkg-config: Use "Requires" for external libs such as talloc.
......................................................................

pkg-config: Use "Requires" for external libs such as talloc.

According to https://people.freedesktop.org/~dbn/pkg-config-guide.html
we should use Requires or even Requires.private, not Libs for external
dependencies.

Change-Id: I2aa716125880b444e091812ab800b29a7b905b4f
---
M libosmocodec.pc.in
M libosmocoding.pc.in
M libosmocore.pc.in
M libosmoctrl.pc.in
M libosmogb.pc.in
M libosmogsm.pc.in
M libosmosim.pc.in
M libosmousb.pc.in
8 files changed, 19 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/19358/1

diff --git a/libosmocodec.pc.in b/libosmocodec.pc.in
index 9e058ef..a6a9d78 100644
--- a/libosmocodec.pc.in
+++ b/libosmocodec.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom Codec related utilities Library
 Description: C Utility Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmocodec
-Cflags: -I${includedir}/ @TALLOC_CFLAGS@
-
+Requires: talloc
+Libs: -L${libdir} -losmocodec
+Cflags: -I${includedir}/
diff --git a/libosmocoding.pc.in b/libosmocoding.pc.in
index d1d03c4..826a3f7 100644
--- a/libosmocoding.pc.in
+++ b/libosmocoding.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom L1 transcoding Library
 Description: C Utility Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmocoding -losmocodec -losmogsm -losmocore
-Cflags: -I${includedir}/ @TALLOC_CFLAGS@
-
+Requires: talloc libosmocodec libosmocgsm libosmocore
+Libs: -L${libdir} -losmocoding
+Cflags: -I${includedir}/
diff --git a/libosmocore.pc.in b/libosmocore.pc.in
index 80f17c8..925265d 100644
--- a/libosmocore.pc.in
+++ b/libosmocore.pc.in
@@ -6,6 +6,7 @@
 Name: Osmocom Core Library
 Description: C Utility Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmocore
+Requires: talloc
+Libs: -L${libdir} -losmocore
 Libs.private: @PTHREAD_LIBS@ @LIBSCTP_LIBS@
-Cflags: -I${includedir}/ @TALLOC_CFLAGS@ @PTHREAD_CFLAGS@
+Cflags: -I${includedir}/ @PTHREAD_CFLAGS@
diff --git a/libosmoctrl.pc.in b/libosmoctrl.pc.in
index 4676b31..c110d8e 100644
--- a/libosmoctrl.pc.in
+++ b/libosmoctrl.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom Control Interface Library
 Description: C Utility Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmoctrl -losmogsm -losmocore
+Requires: talloc libosmogsm libosmocore
+Libs: -L${libdir} -losmoctrl
 Cflags: -I${includedir}/
-
diff --git a/libosmogb.pc.in b/libosmogb.pc.in
index a163cc4..769fea4 100644
--- a/libosmogb.pc.in
+++ b/libosmogb.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom GPRS Gb Library
 Description: Osmocom GPRS Gb Interface (NS/BSSGP) Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore
+Requires: talloc libosmovty libosmocore
+Libs: -L${libdir} -losmogb
 Cflags: -I${includedir}/ -fno-strict-aliasing
-
diff --git a/libosmogsm.pc.in b/libosmogsm.pc.in
index 0160be8..956897b 100644
--- a/libosmogsm.pc.in
+++ b/libosmogsm.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom GSM Core Library
 Description: GSM Core Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmogsm -losmocore
+Requires: talloc libosmocore
+Libs: -L${libdir} -losmogsm
 Cflags: -I${includedir}/
-
diff --git a/libosmosim.pc.in b/libosmosim.pc.in
index 83777c3..fbcdbe4 100644
--- a/libosmosim.pc.in
+++ b/libosmosim.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom SIM card related utilities Library
 Description: C Utility Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmosim -losmocore
+Requires: talloc libosmocore
+Libs: -L${libdir} -losmosim
 Cflags: -I${includedir}/
-
diff --git a/libosmousb.pc.in b/libosmousb.pc.in
index ce6d271..4027074 100644
--- a/libosmousb.pc.in
+++ b/libosmousb.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom libusb (USB) integration
 Description: C Utility Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmousb -losmocore
+Requires: talloc libosmocore
+Libs: -L${libdir} -losmousb
 Cflags: -I${includedir}/
-

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19358
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2aa716125880b444e091812ab800b29a7b905b4f
Gerrit-Change-Number: 19358
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200721/39a05031/attachment.htm>


More information about the gerrit-log mailing list