Change in osmo-e1d[master]: implement buffering to chunks in E1->application direction

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Tue Jul 21 07:34:09 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19345 )

Change subject: implement buffering to chunks in E1->application direction
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Minor naming comment but not really blocking.

https://gerrit.osmocom.org/c/osmo-e1d/+/19345/2/src/intf_line.c 
File src/intf_line.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/19345/2/src/intf_line.c@391 
PS2, Line 391: 		rv = _tsbuf_append(ts, buf, len);
I would have gone with _e1_rx_raw() just for consistency with the HDLCFS case.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19345
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I807671bc6f2acaef740ce215b8d8abcb5dce2640
Gerrit-Change-Number: 19345
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Jul 2020 07:34:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200721/dcb5f705/attachment.htm>


More information about the gerrit-log mailing list