Change in osmo-gsm-tester[master]: report: fix runtime error when suite.duration is None

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jul 20 14:31:43 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19332 )

Change subject: report: fix runtime error when suite.duration is None
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19332/1/src/osmo_gsm_tester/core/report.py 
File src/osmo_gsm_tester/core/report.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19332/1/src/osmo_gsm_tester/core/report.py@118 
PS1, Line 118:         time += suite.duration if suite.duration is not None else 0
I think it makes more sense to simply set self.duration = 0 instead of None in suite.py __init__(). Agree? please update patch with that change instead.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7696350edf801e181e6804ecdbfe83545a912dc3
Gerrit-Change-Number: 19332
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Jul 2020 14:31:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200720/0332e82c/attachment.htm>


More information about the gerrit-log mailing list