Change in osmo-pcu[master]: bts: cosmetic: use DUMMY_VEC for padding where possible

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 19 11:27:45 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19308 )

Change subject: bts: cosmetic: use DUMMY_VEC for padding where possible
......................................................................

bts: cosmetic: use DUMMY_VEC for padding where possible

Change-Id: I725a7bd1b0c4d2b0d73f1b6d1f16543bf3d9d9fe
---
M src/bts.cpp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/bts.cpp b/src/bts.cpp
index 617cd78..22b4c08 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -884,7 +884,7 @@
 send_imm_ass_rej:
 	/* Allocate a bit-vector for RR Immediate Assignment [Reject] */
 	struct bitvec *bv = bitvec_alloc(22, tall_pcu_ctx); /* without plen */
-	bitvec_unhex(bv, "2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b");
+	bitvec_unhex(bv, DUMMY_VEC); /* standard '2B'O padding */
 
 	if (rc != 0) {
 		LOGP(DRLCMAC, LOGL_DEBUG, "Tx Immediate Assignment Reject on AGCH\n");
@@ -970,7 +970,7 @@
 
 	LOGPTBF(tbf, LOGL_INFO, "TX: START Immediate Assignment Downlink (PCH)\n");
 	bitvec *immediate_assignment = bitvec_alloc(22, tall_pcu_ctx); /* without plen */
-	bitvec_unhex(immediate_assignment, "2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b");
+	bitvec_unhex(immediate_assignment, DUMMY_VEC); /* standard '2B'O padding */
 	/* use request reference that has maximum distance to current time,
 	 * so the assignment will not conflict with possible RACH requests. */
 	LOGP(DRLCMAC, LOGL_DEBUG, " - TRX=%d (%d) TS=%d TA=%d pollFN=%d\n",

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19308
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I725a7bd1b0c4d2b0d73f1b6d1f16543bf3d9d9fe
Gerrit-Change-Number: 19308
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200719/5d560e65/attachment.htm>


More information about the gerrit-log mailing list