Change in osmo-pcu[master]: encoding: drop log_alert_exit(), use OSMO_ASSERT() instead

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jul 18 16:30:25 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19309 )

Change subject: encoding: drop log_alert_exit(), use OSMO_ASSERT() instead
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> why? isn't it good to alert through OML?

Well, what would the operator of the BSC/BTS see? If osmo-pcu fails to encode an octet-aligned payload as required by the specs., it's definitely a bug in osmo-pcu. It should never happen.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id5ef1c3c08dc7f264ad801e519d727d86f5ae5b8
Gerrit-Change-Number: 19309
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 18 Jul 2020 16:30:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200718/e3d6c675/attachment.htm>


More information about the gerrit-log mailing list