Change in libosmocore[master]: rate_ctr: Add functions to reset rate counter (groups)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 16 11:18:21 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19294 )

Change subject: rate_ctr: Add functions to reset rate counter (groups)
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/19294/3/include/osmocom/core/rate_ctr.h 
File include/osmocom/core/rate_ctr.h:

https://gerrit.osmocom.org/c/libosmocore/+/19294/3/include/osmocom/core/rate_ctr.h@119 
PS3, Line 119: void rate_ctr_reset_ctr(struct rate_ctr *ctr);
Since structs are called rate_ctr and rate_ctr_group:
rate_ctr_reset()
rate_ctr_group_reset()


https://gerrit.osmocom.org/c/libosmocore/+/19294/3/src/rate_ctr.c 
File src/rate_ctr.c:

https://gerrit.osmocom.org/c/libosmocore/+/19294/3/src/rate_ctr.c@448 
PS3, Line 448:         rate_ctr_for_each_counter(ctrg, reset_rate_ctr_handler, NULL);
Since we are inside the implementation here, it may make sense to simply iterate directly to avoid calling function pointers like crazy.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19294
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If2f806d044cd0fb6929dac44ef8f8a15941ffe9b
Gerrit-Change-Number: 19294
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Jul 2020 11:18:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200716/4054b993/attachment.htm>


More information about the gerrit-log mailing list