This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19256 ) Change subject: e1_input: Use osmo_use_count in e1inp_line ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/libosmo-abis/+/19256/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/19256/1//COMMIT_MSG@9 PS1, Line 9: struct e1inp_line fields changing is fine since it is allocated through : an API and a pointer should be used by clients. > it is fine for API compatibility but definitely breaks ABI. Ah indeed I wanted to keep the old recount field unused and add this to the end, but I forgot to do so after going through all the fixes. https://gerrit.osmocom.org/c/libosmo-abis/+/19256/1/include/osmocom/abis/e1_input.h File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/19256/1/include/osmocom/abis/e1_input.h@249 PS1, Line 249: e1inp_line_clone > This is a public API, so I don't think you can change it. It's not being used out of libosmo-abis by any known osmocom program, so I went through in this case. https://gerrit.osmocom.org/c/libosmo-abis/+/19256/1/include/osmocom/abis/e1_input.h@251 PS1, Line 251: Deprecated, use e1inp_line_get2() instead > OSMO_DEPRECATED()? Indeed, I forgot to do so. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0658b2e9c452598025cc0f1d0b060076171767cc Gerrit-Change-Number: 19256 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 15 Jul 2020 11:06:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200715/69e233b9/attachment.htm>