Change in osmo-bsc[master]: Don't print 'bogus channel load sample' message if total == 0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 15 09:23:10 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19132 )

Change subject: Don't print 'bogus channel load sample' message if total == 0
......................................................................

Don't print 'bogus channel load sample' message if total == 0

Change-Id: I857fecc76dc16ba4431f3c0142bb0d798a9f73dc
Closes: OS#4614
---
M src/osmo-bsc/chan_alloc.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/osmo-bsc/chan_alloc.c b/src/osmo-bsc/chan_alloc.c
index f23a982..9b80df3 100644
--- a/src/osmo-bsc/chan_alloc.c
+++ b/src/osmo-bsc/chan_alloc.c
@@ -203,9 +203,11 @@
 	}
 
 	/* Check for invalid samples (shouldn't happen). */
-	if (total == 0 || used > total) {
+	if (used > total) {
 		LOG_BTS(bts, DRLL, LOGL_NOTICE, "bogus channel load sample (used=%"PRIu64" / total=%"PRIu32")\n",
 			used, total);
+	}
+	if (total == 0 || used > total) {
 		bts->T3122 = 0; /* disable override of network-wide default value */
 		bts->chan_load_samples_idx = 0; /* invalidate other samples collected so far */
 		return;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19132
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I857fecc76dc16ba4431f3c0142bb0d798a9f73dc
Gerrit-Change-Number: 19132
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200715/e66aeb9e/attachment.htm>


More information about the gerrit-log mailing list