Change in osmo-mgw[master]: libosmo-mgcp-client: fix memleak in case if no response is received

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 15 08:43:42 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18881 )

Change subject: libosmo-mgcp-client: fix memleak in case if no response is received
......................................................................


Patch Set 5:

Other topics:

a) why are we actually ending up in this code path? As the comment in the code clearly states, the user should always shut down cleanly. and the "abrupt" is actually an error message.
b) given that we are in an "this should not happen" path, we might simply bypass creating/storing the 'response_pending' in this situation.

So it seems to me, that irrespective how we fix this here, there is an additional bug in the application leading to this situation which must be fixed.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18881
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e89f31685a0822e5cb147a06cc1fc68efc1ec4
Gerrit-Change-Number: 18881
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Jul 2020 08:43:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200715/4ffd9ada/attachment.htm>


More information about the gerrit-log mailing list