This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19233 ) Change subject: Fix HDLC-FCS transmit side ...................................................................... Fix HDLC-FCS transmit side If we are not able to read more packets from the user application, the recv/read call will return 0 and set errno = EAGAIN. In this situation we cannot bail out but still ask the HDLC code to generate output (sequences of flag octets). If we fail to do that, we will transmit all-ones pattern instaed of all-flag octets. Change-Id: Id3bc76f1956138dcd9cb7b499f7251cd94af1329 --- M src/intf_line.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/intf_line.c b/src/intf_line.c index 5994805..4c9c404 100644 --- a/src/intf_line.c +++ b/src/intf_line.c @@ -194,7 +194,7 @@ rv, osmo_hexdump(ts->tx_buf, rv)); ts->tx_len = rv; ts->tx_ofs = 0; - } else if (rv < 0) + } else if (rv < 0 && errno != EAGAIN) return rv; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id3bc76f1956138dcd9cb7b499f7251cd94af1329 Gerrit-Change-Number: 19233 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200712/8af1f38c/attachment.htm>