Change in osmo-ttcn3-hacks[master]: bsc: test RR Channel Release EARFCNs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jul 11 06:42:29 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216 )

Change subject: bsc: test RR Channel Release EARFCNs
......................................................................


Patch Set 1:

(8 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/bsc/BSC_Tests.ttcn 
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/bsc/BSC_Tests.ttcn@1472 
PS1, Line 1472: 		
ws


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/bsc/BSC_Tests.ttcn@1794 
PS1, Line 1794: 	
ws


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn 
File library/GSM_RR_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1074 
PS1, Line 1074: CellSelectionIndicatorValue
It makes sense to shorten names a bit, e.g. CellSelIndValue.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1087 
PS1, Line 1087: CellSelectionIndicatorValueEnum
Not sure if this type is going to be used outside, so let's make it 'private'. Same applies to other potentially 'private' types.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1109 
PS1, Line 1109: arfcn
uarfcn?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1131 
PS1, Line 1131: define not_allowed_cells
See GSM_RestOctets.EUTRAN_RepeatedNotAllowedCells (incomplete implementation).


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1134 
PS1, Line 1134: target_pcid
Can we use GSM_RestOctets.EUTRAN_PCID2TAMaps here?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1154 
PS1, Line 1154: meas_bw_presence
Unused argument. I don't think it's even needed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I882c5e1f70bcc4833fc837a95c900ce291919cc5
Gerrit-Change-Number: 19216
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sat, 11 Jul 2020 06:42:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200711/0c49f90a/attachment.htm>


More information about the gerrit-log mailing list