Change in osmo-trx[master]: Transceiver: Fix race condition obtaining Dl burst from Upper layer

[pespin]

Hello fixeria, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-trx/+/19206

to look at the new patch set (#3).

Change subject: Transceiver: Fix race condition obtaining Dl burst from Upper layer
......................................................................

Transceiver: Fix race condition obtaining Dl burst from Upper layer

The queue was being accessed sequentially obtaining and releasing the
mutual exclusion zone twice. First in getStaleBurst() dropping all
FN<currTime, then in getCurrentBurst() trying to obtain FN=currTime.

However, since in between the mutex is released, it could happen that
for instance upper layer would introduce currTime-1 in the queue, which
would make then getCurrentBurst() detect that one instead of potential
currTime in the queue and return NULL.

By holding the mutex during the call to both functions we make sure the
state is kept during the whole transaction.

Related: OS#4487 (comment #7)
Change-Id: If1fd8d7fc5f21ee2894192ef1ac2a3cdda6bbb98
---
M Transceiver52M/Transceiver.cpp
M Transceiver52M/radioVector.cpp
M Transceiver52M/radioVector.h
3 files changed, 17 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/06/19206/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19206
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If1fd8d7fc5f21ee2894192ef1ac2a3cdda6bbb98
Gerrit-Change-Number: 19206
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200710/ae4d86a3/attachment.htm>