This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/19173 )
Change subject: gtp: queue_test: Fix printf gcc warn under ARM
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-ggsn/+/19173/1/tests/gtp/queue_test.c
File tests/gtp/queue_test.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/19173/1/tests/gtp/queue_test.c@31
PS1, Line 31: printf("%d\t%d\t%d\t%d\t%d\t%d\t%u\t%" PRIuPTR "\n",
> So what are we printing here? An integer that is stored in as a pointer? […]
Yes, the problem is that since pointer type length is arch-dependent, the filling of 0 in representation of %p would break expected output (eg 0x0034 vs 0x000000034).
%u would work on some architectures (ARM 32 bit), and wouldn't on some others. That's why I'm using the standard uintptr_t and is printf representation. On my system:
/usr/include/inttypes.h
45:# define __PRIPTR_PREFIX "l"
163:# define PRIuPTR __PRIPTR_PREFIX "u"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/19173
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie9530cdd191386ca3f6c336684f81c4582c4d962
Gerrit-Change-Number: 19173
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jul 2020 10:24:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200710/8ae1d872/attachment.htm>