Change in osmocom-bb[master]: trxcon/scheduler: check TDMA frame order, drop out of order bursts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 10 09:27:15 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19201 )

Change subject: trxcon/scheduler: check TDMA frame order, drop out of order bursts
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmocom-bb/+/19201/4/src/host/trxcon/sched_trx.c 
File src/host/trxcon/sched_trx.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/19201/4/src/host/trxcon/sched_trx.c@646 
PS4, Line 646: 	if (elapsed < 0) {
It's a bit weird having this if here and then the other 2 conditional blocks checking for related stuff being chained together below through if else.


https://gerrit.osmocom.org/c/osmocom-bb/+/19201/4/src/host/trxcon/sched_trx.c@650 
PS4, Line 650: 					"processed fn=%u (see OS#4658) => dropping\n",
I'd say there's no need to ask the user to look at a ticket everytime, simply putting it in the code whenever the user wants to investigate further is enough imho.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I873c8555ea2ca190b1689227bb0fdcba87188772
Gerrit-Change-Number: 19201
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jul 2020 09:27:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200710/d8f7a321/attachment.htm>


More information about the gerrit-log mailing list