This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19210 ) Change subject: RR Release Cell selection IE: fix presence bit for repeated EARFCNs ...................................................................... RR Release Cell selection IE: fix presence bit for repeated EARFCNs 3GPP 44.018 10.5.2.1e defines the EARFCNs encoded in the 'Cell selection indicator after release of all TCH and SDCCH IE' as follows: <Cell Selection Indicator after release of all TCH and SDCCH value part> ::= [...] | 011 { 1 <E-UTRAN Description : < E-UTRAN Description struct >> } ** 0 So after a 3-bit discriminator of '3' there can be multiple E-UTRAN Descriptions, and each of them starts with a '1' bit to indicate that another item follows. Before this patch, osmo-bsc only encoded the first '1' bit, and failed to repeat this before each following E-UTRAN Description. Fix that by moving the '1' encoding into the loop. Related: SYS#4871 SYS#4872 Change-Id: I59e427e4ebb1c6af99b27a15c40fed82457ac8ab --- M src/osmo-bsc/gsm_04_08_rr.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/19210/1 diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c index f47c31f..635b8a2 100644 --- a/src/osmo-bsc/gsm_04_08_rr.c +++ b/src/osmo-bsc/gsm_04_08_rr.c @@ -255,7 +255,6 @@ /* E-UTRAN Description */ bitvec_set_uint(&bv, 3, 3); - bitvec_set_bit(&bv, 1); for (i = 0; i < MAX_EARFCN_LIST; i++) { const struct osmo_earfcn_si2q *e = &bts->si_common.si2quater_neigh_list; @@ -266,6 +265,7 @@ LOGP(DRR, LOGL_NOTICE, "%s: Not enough room to store EARFCN %u in the " "Cell Selection Indicator IE\n", gsm_bts_name(bts), e->arfcn[i]); } else { + bitvec_set_bit(&bv, 1); bitvec_set_uint(&bv, e->arfcn[i], 16); /* No "Measurement Bandwidth" */ bitvec_set_bit(&bv, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I59e427e4ebb1c6af99b27a15c40fed82457ac8ab Gerrit-Change-Number: 19210 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200710/c6c06cc1/attachment.htm>