Change in osmo-e1d[master]: usb.c: Fix error introducing Tx underflows

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jul 9 20:54:27 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19209 )


Change subject: usb.c: Fix error introducing Tx underflows
......................................................................

usb.c: Fix error introducing Tx underflows

In Change-Id I7d4d4ab39cb3e7e6a7eb8e738a367122eb3fbee2 I inroduced
a bug that would cause e1_usb_xfer_out() to return four bytes too
little, which in turn causes E1 Tx underflows to happen in the device
firmware.

Change-Id: I71675d4de781421286f0d1febedfdb1f7b523c38
---
M src/usb.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/09/19209/1

diff --git a/src/usb.c b/src/usb.c
index e8cd212..7a5dce2 100644
--- a/src/usb.c
+++ b/src/usb.c
@@ -135,7 +135,7 @@
 
 	memset(buf, 0xff, 4);
 
-	return e1_line_mux_out(line, buf+4, fts);
+	return e1_line_mux_out(line, buf+4, fts) + 4;
 }
 
 static int

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19209
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I71675d4de781421286f0d1febedfdb1f7b523c38
Gerrit-Change-Number: 19209
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/55ead683/attachment.htm>


More information about the gerrit-log mailing list