Change in osmo-gsm-tester[master]: enb_amarisoft: add option to enable and configure DL AWGN channel

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Thu Jul 9 12:28:30 UTC 2020


srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 )

Change subject: enb_amarisoft: add option to enable and configure DL AWGN channel
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py 
File src/osmo_gsm_tester/obj/enb_amarisoft.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py@164 
PS1, Line 164:         config.overlay(values, dict(enb={'dl_awgn_snr': values['enb'].get('dl_awgn_snr', 30)}))
> Looks like you only really need to add 30 to defaults.conf and get rid of this line? […]
Good idea about the false in the defaults.conf.
But I think the boolean to enable/disable it is still needed. Note that basically any real value is a valid SNR. Ok, -1000 is not realistic but I guess rather than using such a magic number we can have the boolean and make it explicit.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40
Gerrit-Change-Number: 19185
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2020 12:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/2bd0e741/attachment.htm>


More information about the gerrit-log mailing list