Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jul 9 10:56:47 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 )

Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h 
File include/osmocom/gsm/protocol/gsm_12_21.h:

https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h@514 
PS2, Line 514: , /*
not sure if it is legal to have two enum members map to the same value (NM_ATT_BS11_PASSWORD just a few lines above).  We may have to eithe use unique values, or move to a different enum or #defines for the osmcoom specific NM_ATT.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588
Gerrit-Change-Number: 19146
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2020 10:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/df20769d/attachment.htm>


More information about the gerrit-log mailing list