Change in libosmocore[master]: socket.c add osmo_sockaddr_valid()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jul 9 10:52:18 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19144 )

Change subject: socket.c add osmo_sockaddr_valid()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/19144/2/src/socket.c 
File src/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/19144/2/src/socket.c@1532 
PS2, Line 1532: 	if (addr->u.sas.ss_family == AF_INET) {
> So indeed you are using one of the fields in a substruct of the union to find out the type. […]
it's a non-issue  AFAICT, see my comment to another patch.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19144
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib6fb050e1bfe3f3a8d8bbe5e762351ce6b7cc48c
Gerrit-Change-Number: 19144
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 09 Jul 2020 10:52:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/4db41fc9/attachment.htm>


More information about the gerrit-log mailing list