Change in osmo-pcu[master]: pdch.cpp: Avoid resetting (egprs_)ms_class to unknown if not found in...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jul 9 10:05:50 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19195 )

Change subject: pdch.cpp: Avoid resetting (egprs_)ms_class to unknown if not found in MS RadioAccCap
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/src/pdch.cpp@a604 
PS1, Line 604: 				ms->egprs_ms_class());
> isn't this interesting to still see in, say, a DEBUG log?
the commitlog states it is already logged in another place.


https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/tests/tbf/TbfTest.err 
File tests/tbf/TbfTest.err:

https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/tests/tbf/TbfTest.err@a3113 
PS1, Line 3113: EGPRS MS class 0 -> 1
likely this is where it is logged already, just one line above.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19195
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Icd52209fd4395d78dc770e7869d1b1fe45a18ca0
Gerrit-Change-Number: 19195
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2020 10:05:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/eb8acc70/attachment.htm>


More information about the gerrit-log mailing list