Change in osmo-pcu[master]: pdch.cpp: Fix wrong annoying log line about non-scheduled ResourceReq...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Jul 9 00:34:41 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19196 )

Change subject: pdch.cpp: Fix wrong annoying log line about non-scheduled ResourceReq received
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/19196/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/19196/1/src/pdch.cpp@574 
PS1, Line 574: 				  "MS requests UL TBF in PACKET RESOURCE REQ of "
(seems odd to trivially tweak the log message to uppercase; in the test log other logging still prints it lowercase. maybe use 120 width?)


https://gerrit.osmocom.org/c/osmo-pcu/+/19196/1/src/pdch.cpp@580 
PS1, Line 580: 		   TBF when last one has finished. */
(comment '*'s)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19196
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4b4367126d6a16055cd2f45afc4a6b9c15a7c980
Gerrit-Change-Number: 19196
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2020 00:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/96d53401/attachment.htm>


More information about the gerrit-log mailing list