This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19170 ) Change subject: libosmo-mgcp: always check result of msgb_printf() in add_fmtp() ...................................................................... libosmo-mgcp: always check result of msgb_printf() in add_fmtp() Change-Id: I218ac21612116366eabd0c75ce3648bad4e27abf --- M src/libosmo-mgcp/mgcp_sdp.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c index a7478ad..5fa6bdb 100644 --- a/src/libosmo-mgcp/mgcp_sdp.c +++ b/src/libosmo-mgcp/mgcp_sdp.c @@ -478,6 +478,8 @@ for (i = 0; i < fmtp_params_len; i++) { rc = msgb_printf(sdp, "a=fmtp:%u", fmtp_params[i].payload_type); + if (rc < 0) + return -EINVAL; /* Add amr octet align parameter */ if (fmtp_params[i].param.amr_octet_aligned_present) { -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I218ac21612116366eabd0c75ce3648bad4e27abf Gerrit-Change-Number: 19170 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Assignee: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: dexter <pmaier at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200708/f9ee7b42/attachment.htm>