This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19176 ) Change subject: encoding: Encode TA as unsigned and check validty against GSM48_TA_INVALID ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/19176/1/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19176/1/src/encoding.cpp@147 PS1, Line 147: GSM48_TA_INVALID Maybe rather '> 63'? Anything grater than 63 (0b111111) would not fit into a 6 bit field. https://gerrit.osmocom.org/c/osmo-pcu/+/19176/1/src/encoding.cpp@583 PS1, Line 583: Unrelated change. https://gerrit.osmocom.org/c/osmo-pcu/+/19176/1/src/encoding.cpp@597 PS1, Line 597: Unrelated change. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I82b13561d0fe5ebafb5c3a8b9a501045c29809bc Gerrit-Change-Number: 19176 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jul 2020 17:00:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200707/b87694c0/attachment.htm>