This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19121 ) Change subject: mgcp_vty: fix endpoint number configuration ...................................................................... Patch Set 4: (10 comments) (ensuring all messages are sent) https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/include/osmocom/mgcp/mgcp_trunk.h@51 PS2, Line 51: } virtual; > better to use a different name, because 'virtual' is a C++ keyword... virt or virtual_trunk or ... […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_trunk.c File src/libosmo-mgcp/mgcp_trunk.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_trunk.c@51 PS2, Line 51: trunk->trunk_nr = nr; > (unrelated whitespace change) This is intentional. I want to have the trunk specific and the generic settings grouped. https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_trunk.c@87 PS2, Line 87: offset_endpoints = 1; > (naming: first_endp_id or first_endp_nr? "offset" to me indicates that we are skipping some items in […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_trunk.c@99 PS2, Line 99: * however miss-initalation of the struct or memory corruption > 'initialization' Done https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_trunk.c@103 PS2, Line 103: > Note that the vty allows vty_number_endpoints to be 0, in which case we probably should not invoke t […] We should make sure that the VTY forces to create at least one endpoints. I have fixed it there now. https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_trunk.c@105 PS2, Line 105: trunk->endpoints = _talloc_zero_array(trunk->cfg, > (separate issue: seems sketchy to use an API function that starts with an underscore and that isn't […] I have fixed that in a different patch. https://gerrit.osmocom.org/c/osmo-mgw/+/19121/3/src/libosmo-mgcp/mgcp_trunk.c File src/libosmo-mgcp/mgcp_trunk.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19121/3/src/libosmo-mgcp/mgcp_trunk.c@45 PS3, Line 45: trunk->virtual.vty_number_endpoints = 32; : trunk->e1.vty_timeslot_first = 1; : trunk->e1.vty_timeslot_num = 2; > I would not make this vty configurable. […] Just thought that a bit of flexibility would not hurt. So we make it static: first timeslot is 1 and last one is 32. Maybe it would be a compromise to put a default config that opens all timeslots. Then we would not need to syncronize the configs, but should it be necessary we have the option to do so. https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_vty.c@713 PS2, Line 713: "number endpoints <0-65534>", > ...this is where vty_number_endpoints == 0 is allowed by the vty. […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_vty.c@936 PS2, Line 936: vty_out(vty, " timeslot first %u%s", > Preferably add new vty commands in a separate patch, because the commit log says "refactor" You are probably right, this patch is more about adding features. The refactoring is just a minimal side effect. https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_vty.c@1179 PS2, Line 1179: "Timeslot options\n" "Number of E1 timeslots to use\n" "E1 timeslot count\n") > explain whether the used E1 timeslots end up being [first .. first+num] or [first .. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I73b31e3c236a61ea0a6f76ef5ff98ce589f52c77 Gerrit-Change-Number: 19121 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 07 Jul 2020 14:10:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200707/6f54830a/attachment.htm>