This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19075 ) Change subject: mgcp_client: add function to generate e1-endpoint names ...................................................................... Patch Set 6: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/19075/6/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19075/6/src/libosmo-mgcp-client/mgcp_client.c@934 PS6, Line 934: osmo-mgw only allows a maximum of 64 trunks. The trunk id 0 is : * reserved due to historical reasons. */ : if (trunk_id == 0 || trunk_id > 64) { : LOGP(DLMGCP, LOGL_ERROR, "Cannot compose MGCP e1-endpoint name, trunk number (%u) is not entirely sure if we should constrain the client to what [current] osmo-mgw allows. I would permit it here and have osmo-mgw refuse/reject it, if it is unsupported. https://gerrit.osmocom.org/c/osmo-mgw/+/19075/6/src/libosmo-mgcp-client/mgcp_client.c@941 PS6, Line 941: An E1 line has a maximum of 32 timeslots, while the first (ts=0) is : * reserverd for signalling, so we can not use it here. */ TS0 is not really used for signalling (Q.931, Abis, SCCP, ...) but for framing/alignment. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iec35b5bae8a7b07ddb3559f7114a24dcd10e8f14 Gerrit-Change-Number: 19075 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 06 Jul 2020 19:06:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200706/b729b499/attachment.htm>