Change in osmo-ttcn3-hacks[master]: bsc: add SI2quater tests for multiple EARFCNs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Jul 6 17:07:59 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19152 )

Change subject: bsc: add SI2quater tests for multiple EARFCNs
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review-1
> 
> Please use use template inheritance (see 'modifies' keyword [1]), so there would be no need to define the same template with the same fields (with some exceptions) again and again. See also [2]. In your case, incremental inheritance should be possible, i.e. the template with 2 E-ARFCNs may be inherited from the template with 1 E-ARFCN, the one with 3 E-ARFCNs may be inherited from the old with 2 E-ARFCNs and so on.
> 
> [1] ETSI ES 201 873-1, section 15.5 "Modified templates"
> [2] https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19114

ah yes I was planning on that but forgot when all the tests were nice and green :P


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19152
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I45382f88686ca60e68569e93569fc4cfb63a0e0d
Gerrit-Change-Number: 19152
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Jul 2020 17:07:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200706/3b064610/attachment.htm>


More information about the gerrit-log mailing list