Change in osmo-ttcn3-hacks[master]: GSM_SystemInformation: add SI2quater

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jul 6 17:06:02 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19149 )

Change subject: GSM_SystemInformation: add SI2quater
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19149/3/library/GSM_SystemInformation.ttcn 
File library/GSM_SystemInformation.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19149/3/library/GSM_SystemInformation.ttcn@147 
PS3, Line 147:  rest_octets
> oh gawd i hate tabs like that but ok whatever […]
I am also not happy about the mixed tab/space alignment that we use in C for functions with multi-line arguments, but if I see that all functions in a file are aligned, I will also do this. Neither my editor does this automatically, so I do this myself too.

Everybody could just say "I prefer this way" or "I hate this thing", but in the end our code would turn into a mix of different styles and preferences. And nobody would be happy in the end.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I879c37eb51ece55d79346c6bf1a4951c3f11c77e
Gerrit-Change-Number: 19149
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Jul 2020 17:06:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200706/35540da6/attachment.htm>


More information about the gerrit-log mailing list