This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19119 ) Change subject: mgcp_trunk: remove double check ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/19119/2/src/libosmo-mgcp/mgcp_trunk.c File src/libosmo-mgcp/mgcp_trunk.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19119/2/src/libosmo-mgcp/mgcp_trunk.c@164 PS2, Line 164: return mgcp_trunk_by_num(cfg, MGCP_TRUNK_E1, trunk_nr); It looks to me like now mgcp_trunk_by_name() no longer works for epname that contain the virtual trunk prefix. Above condition returns the trunk only for trunk_nr > 0, i.e. not including the virtual trunk, and below conditions match only for epnames that lack a trunk prefix. right? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I91fb8cf6e3b077ba8f18fdbcd071275c6fd7cacd Gerrit-Change-Number: 19119 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 06 Jul 2020 13:36:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200706/11bfb3b4/attachment.htm>