This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19067 ) Change subject: Revert "gsmtap_makemsg_ex: NULL for unknown chan_type" ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19067/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/19067/2//COMMIT_MSG@11 PS2, Line 11: being able to determine channel type. a bit hard to understand why. maybe reword to something like: These callers rely on a NULL return value for unknown channel type: - gsmtap_send() - osmo-bts/src/osmo-bts-virtual/scheduler_virtbts.c _tx_to_virt_um() With the reverted patch, they would send invalid GSMTAP data. but do they? Do any callers regularly pass GSMTAP_CHANNEL_UNKNOWN? If you saw fallout that would be nice to know. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ebaa89cc3422df1d7fd2365a6176cb2902d1c67 Gerrit-Change-Number: 19067 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 06 Jul 2020 12:05:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200706/5c70c267/attachment.htm>