This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19143 ) Change subject: socket.c: introduce osmo_sock_init3 & osmo_sock_init3_ofd ...................................................................... Patch Set 2: Code-Review-1 (5 comments) https://gerrit.osmocom.org/c/libosmocore/+/19143/2/include/osmocom/core/socket.h File include/osmocom/core/socket.h: https://gerrit.osmocom.org/c/libosmocore/+/19143/2/include/osmocom/core/socket.h@69 PS2, Line 69: int osmo_sock_init3(uint16_t type, uint8_t proto, Looks like it'd be better keeping current order. Move osmo_sock_init3 above and leave the _ofd here. https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@448 PS2, Line 448: #define OSMO_SOCKADDR_TO_STR(sockaddr) \ I don't get how this macro is supposed to work. It's storing it into a local variable defined by the macro? this looks really strange. https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@451 PS2, Line 451: strcpy(sastr.ip, "Invalid IP") osmo_strlcpy https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@453 PS2, Line 453: int osmo_sock_init3(uint16_t type, uint8_t proto, Missing documentation https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@931 PS2, Line 931: return osmo_fd_init_ofd(ofd, osmo_sock_init3(type, proto, local, remote, flags)); passing -1 to osmo_fd_init_ofd if osmo_sock_init3 fails? No thanks. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1eece543e3241ef0e095eb63bb831f7c15a16794 Gerrit-Change-Number: 19143 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 06 Jul 2020 08:59:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200706/342d4b18/attachment.htm>