This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19139 ) Change subject: vty: add a define CMD_IPV46 to require a IPv4/6 address ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19139/1/include/osmocom/vty/command.h File include/osmocom/vty/command.h: https://gerrit.osmocom.org/c/libosmocore/+/19139/1/include/osmocom/vty/command.h@307 PS1, Line 307: CMD_IPV46 It may be confusing given that other CMD_* macros accept an argument and match it against some pattern. Maybe rather call it 'CMD_IPV46_STR'? Moreover, you can define both CMD_IPV4_STR and CMD_IPV6_STR separately, so they can be reused like this: #define CMD_IPV46_STR "(" CMD_IPV4_STR "|" CMD_IPV6_STR ")" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I86e399aea86b68b48e627f11e1de48fdfad16525 Gerrit-Change-Number: 19139 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Sun, 05 Jul 2020 11:22:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200705/db25e34b/attachment.htm>