Change in osmo-mgw[master]: mgcp_test: do not access endpoint array elements directly

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Sat Jul 4 08:05:40 UTC 2020


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-mgw/+/19120

to look at the new patch set (#2).

Change subject: mgcp_test: do not access endpoint array elements directly
......................................................................

mgcp_test: do not access endpoint array elements directly

The test assumes that the endpoint "rtpbridge/X at mgw" is at array
position X in many places. This does not necessarly have to match.
Accessing the array elements directly was the prefered way when the MGW
did use integer numbers and not strings to identify endpoints. Since the
endpoint name strings are used to access the endpoints the unit-test
should also reflect this.

Lets replace the integer variable last_endpoint with a string variable
and do related verifications based on strings.

Change-Id: Ic950c427f23be4a792af94972554637c2b0fbdf2
Related: OS#2659
---
M tests/mgcp/mgcp_test.c
1 file changed, 31 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/20/19120/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic950c427f23be4a792af94972554637c2b0fbdf2
Gerrit-Change-Number: 19120
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200704/743d3342/attachment.htm>


More information about the gerrit-log mailing list