This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19024 ) Change subject: refactor: move RESET Osmux TLV parsing to ran_msg_a.c ...................................................................... Patch Set 4: Code-Review+2 (1 comment) combining +2, open CR will be addressed in separate patch https://gerrit.osmocom.org/c/osmo-msc/+/19024/4/src/libmsc/ran_peer.c File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/19024/4/src/libmsc/ran_peer.c@213 PS4, Line 213: ran_peer_update_osmux_support(rp, supports_osmux); > BY moving call to this function here you are also calling it even if rc return error, which is a bit […] the rc is actually of enum reset_msg_type, it has no error codes, only enum reset_msg_type { SCCP_RAN_MSG_NON_RESET = 0, SCCP_RAN_MSG_RESET, SCCP_RAN_MSG_RESET_ACK, }; i notice now that this shouldn't be an int at all. will fix in a separate patch Assuming there were an error code returned, then supports_osmux should also always be returned as 0 ( = "no osmux indication") -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1ad4a3f9356216dd4bf8c48fba29fd23438810a7 Gerrit-Change-Number: 19024 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jul 2020 23:28:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200703/19aab009/attachment.htm>