Change in osmo-bts[master]: bts-trx: Implement ramp up/down during ADM state change

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Fri Jul 3 09:55:17 UTC 2020


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18967 )

Change subject: bts-trx: Implement ramp up/down during ADM state change
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/18967/5/src/osmo-bts-trx/l1_if.c 
File src/osmo-bts-trx/l1_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18967/5/src/osmo-bts-trx/l1_if.c@892 
PS5, Line 892: 		if (mo->procedure_pending) {
I see the potential for a race condition here. Do we handle missing OML ACK/NACK?
I think we should either NACK here instead of ignoring the state change or update the ramping (if that's possible) to ramp back down/up and ACK.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18967
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib7a7b0a0c24779349f142215f0bb32b72c86ce70
Gerrit-Change-Number: 18967
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Jul 2020 09:55:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200703/93f58b4d/attachment.htm>


More information about the gerrit-log mailing list