This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19089 ) Change subject: doc/manuals: Update thread documentation after dropping CTRL sock threads ...................................................................... doc/manuals: Update thread documentation after dropping CTRL sock threads Per-ARFCN CTRL threads managing CTRL socket loops were dropped a while ago, but it was forgotten to udpate the documentation. Change-Id: I34d117325e60b04b075c205d21bb0b827a5e8c52 --- M doc/manuals/chapters/code-architecture.adoc 1 file changed, 5 insertions(+), 10 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/code-architecture.adoc b/doc/manuals/chapters/code-architecture.adoc index 18d0e3a..f1feb2c 100644 --- a/doc/manuals/chapters/code-architecture.adoc +++ b/doc/manuals/chapters/code-architecture.adoc @@ -39,8 +39,7 @@ radioiface [label="RadioInterface"]; radiodev [label="RadioDevice"]; -trans:nw->trans:ne [label="Trx.ControlServiceLoop_0"]; -trans:nw->trans:ne [label="Trx.ControlServiceLoop_1"]; +trans:nw->trans:ne [label="Main"]; trans:w->radioiface:w [label="Trx.TxPriorityQueueServiceLoop_0"]; trans:w->radioiface:w [label="Trx.TxPriorityQueueServiceLoop_1"]; radioiface:e->trans:e [label="Trx.RxServiceLoop_0"]; @@ -92,14 +91,6 @@ Dynamic amount of Threads (1 per RF logical channel on the `Transceiver` instance): -* `ControlServiceLoop`: Handles commands from the Per-ARFCN Control Interface - socket (<<trx_if_control>>). Each thread is responsible for managing one - socket related to one ARFCN or which is the same, to one RF logical channel. - These are the only threads expected to use the private `start()` and `stop()` - methods of the `Transceiver()` class, since those methods don't stop any of - the `ControlServiceLoop` threads as they must keep running to handle new - commands (for instance, to re-start processing samples with the _POWERON_ - command). * `RxServiceLoop`: Each thread of this type pulls bursts from the `RadioInterface` FIFO for one specific logical RF channel and handles it according to the slot and burst correlation type, finally sending proper data @@ -108,6 +99,10 @@ Manager UDP socket (<<trx_if>>), and fills the `RadioInterface` with it setting clock related information. +All the Per-ARFCN Control Interface socket (<<trx_if_control>>) commands are +handled by the event loop runnnig on the main thread. This is the only thread +expected to use the private `start()` and `stop()` methods. + [[code_component_radioiface]] === RadioInterface -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I34d117325e60b04b075c205d21bb0b827a5e8c52 Gerrit-Change-Number: 19089 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200702/27d86ece/attachment.htm>