Change in osmo-mgw[master]: trunk: parse E1 trunk number

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18752 )

Change subject: trunk: parse E1 trunk number
......................................................................


Patch Set 11: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/11/tests/mgcp/mgcp_test.c 
File tests/mgcp/mgcp_test.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/11/tests/mgcp/mgcp_test.c@2144 
PS11, Line 2144: trunk_nr = e1_trunk_nr_from_epname("ds/e1+2/s-1/su16-0");
               : 	OSMO_ASSERT(trunk_nr == 2);
               : 	trunk_nr = e1_trunk_nr_from_epname("xxxxxx3/s-1/su16-0");
               : 	OSMO_ASSERT(trunk_nr == 3);
               : 	trunk_nr = e1_trunk_nr_from_epname("xxxxxx4/zz");
               : 	OSMO_ASSERT(trunk_nr == 4);
I really don't want to delay this patch any longer, but to me it doesn't make sense that we ignore the prefix.  I think we should match that it is always the intended format, i.e. "ds/e1-" as a prefix.  I don't see legitimate use cases of accepting other formats - rather I see potential for accidents where completely unrelated endpoint names sent by accident or misconfiguration would be interpreted as E1 despite not being E1.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18752
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifdaab953544151e73b58cc3e95d21afdb40765f4
Gerrit-Change-Number: 18752
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Jul 2020 09:37:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200702/9400a375/attachment.htm>