Change in osmo-msc[master]: refactor: move RESET Osmux TLV parsing to ran_msg_a.c

[neels]

Hello pespin, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-msc/+/19024

to look at the new patch set (#3).

Change subject: refactor: move RESET Osmux TLV parsing to ran_msg_a.c
......................................................................

refactor: move RESET Osmux TLV parsing to ran_msg_a.c

ran_peer.c is not the proper place to parse messages, because it should be RAN
agnostic. All parsing and encoding belongs in ran_msg_a.c and ran_msg_iu.c.

Move the Osmux TLV parsing into the is_reset_msg op: add supports_osmux
out-parameter (and add a logging fi pointer). To be able to modify msg->l3h,
also make the msgb arg non-const.

In ranap_is_reset_msg(), always return non-support for Osmux.

In bssmap_is_reset_msg(), return 0 if no TLVs were parsed, 1/-1 if an Osmux TLV
was present/not present.

Update the osmux support flag directly where the ConnectionLess message is
received, so that there is only one place responsible for that.

Related: OS#4595
Change-Id: I1ad4a3f9356216dd4bf8c48fba29fd23438810a7
---
M include/osmocom/msc/ran_msg_a.h
M include/osmocom/msc/ran_msg_iu.h
M include/osmocom/msc/sccp_ran.h
M src/libmsc/ran_msg_a.c
M src/libmsc/ran_msg_iu.c
M src/libmsc/ran_peer.c
6 files changed, 60 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/24/19024/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1ad4a3f9356216dd4bf8c48fba29fd23438810a7
Gerrit-Change-Number: 19024
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200701/be3965c7/attachment.htm>