This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17058 ) Change subject: pcsc: don't leak memory ...................................................................... pcsc: don't leak memory Change-Id: I183882ff2eae82754d55189b154863fad9cce4aa --- M src/sim/reader_pcsc.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/sim/reader_pcsc.c b/src/sim/reader_pcsc.c index 9e05e3c..04a8622 100644 --- a/src/sim/reader_pcsc.c +++ b/src/sim/reader_pcsc.c @@ -87,11 +87,14 @@ num_readers++; } - if (num != num_readers) + if (num != num_readers) { + SCardFreeMemory(st->hContext, mszReaders); goto end; + } st->name = talloc_strdup(rh, ptr); st->dwActiveProtocol = -1; + SCardFreeMemory(st->hContext, mszReaders); return rh; end: -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I183882ff2eae82754d55189b154863fad9cce4aa Gerrit-Change-Number: 17058 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200131/10c1f7ed/attachment.htm>