Change in osmo-ccid-firmware[master]: usb dfu header cleanup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jan 28 21:52:30 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17037 )

Change subject: usb dfu header cleanup
......................................................................


Patch Set 1:

(1 comment)

commit log could be a bit more verbose why this is done, ...

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17037/1/sysmoOCTSIM/usb/class/dfu/device/dfudf.c 
File sysmoOCTSIM/usb/class/dfu/device/dfudf.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17037/1/sysmoOCTSIM/usb/class/dfu/device/dfudf.c@67 
PS1, Line 67: 0xfe 
how is the magic value an improvement over a #define?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17037
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I689d7122872b28444b6c5343df3bac0c30f23b1d
Gerrit-Change-Number: 17037
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 28 Jan 2020 21:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200128/970bd1f0/attachment.htm>


More information about the gerrit-log mailing list