This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17035 ) Change subject: git version appended to the product usb string descriptor ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17035/2/sysmoOCTSIM/main.c File sysmoOCTSIM/main.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17035/2/sysmoOCTSIM/main.c@369 PS2, Line 369: if(2+in_sz*2 < out_sz) if only if() was a function, or for(),... It is of course a waste of all of our time to go through review cycles because of it, but I would like to kindly ask you to try to observe coding style before pushing to gerrit. Thanks :) -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I4a9d010c9025cf8c14ebaf42de048b9a172c7786 Gerrit-Change-Number: 17035 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 28 Jan 2020 21:51:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200128/88429fd8/attachment.htm>