Change in osmo-pcu[master]: tests/rlcmac: Don't check stderr output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Jan 25 19:33:01 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16992 )

Change subject: tests/rlcmac: Don't check stderr output
......................................................................

tests/rlcmac: Don't check stderr output

Current stderr output is empty anyway, and not checking it allows
enavling different log levels to easily debug issues.

Change-Id: I5b12e919e08a6eeaad31a459e5a15fdee4d76a61
---
M tests/Makefile.am
D tests/rlcmac/RLCMACTest.err
M tests/testsuite.at
3 files changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/tests/Makefile.am b/tests/Makefile.am
index c599636..c9a376f 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -136,7 +136,7 @@
 
 EXTRA_DIST = \
 	testsuite.at $(srcdir)/package.m4 $(TESTSUITE)	\
-	rlcmac/RLCMACTest.ok rlcmac/RLCMACTest.err \
+	rlcmac/RLCMACTest.ok \
 	alloc/AllocTest.ok alloc/AllocTest.err \
 	tbf/TbfTest.err \
 	bitcomp/BitcompTest.ok bitcomp/BitcompTest.err \
diff --git a/tests/rlcmac/RLCMACTest.err b/tests/rlcmac/RLCMACTest.err
deleted file mode 100644
index e69de29..0000000
--- a/tests/rlcmac/RLCMACTest.err
+++ /dev/null
diff --git a/tests/testsuite.at b/tests/testsuite.at
index 8a319bd..fe87ff9 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -5,8 +5,7 @@
 AT_SETUP([rlcmac])
 AT_KEYWORDS([rlcmac])
 cat $abs_srcdir/rlcmac/RLCMACTest.ok > expout
-cat $abs_srcdir/rlcmac/RLCMACTest.err > experr
-AT_CHECK([$OSMO_QEMU $abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [experr])
+AT_CHECK([$OSMO_QEMU $abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [ignore])
 AT_CLEANUP
 
 AT_SETUP([multi_slot])

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16992
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5b12e919e08a6eeaad31a459e5a15fdee4d76a61
Gerrit-Change-Number: 16992
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200125/e91949e9/attachment.htm>


More information about the gerrit-log mailing list