Change in osmo-pcu[master]: gsm_timer: fix comparison of constant LONG_MAX with an integer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jan 25 18:17:20 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17006 )

Change subject: gsm_timer: fix comparison of constant LONG_MAX with an integer
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > That looks like a specialvalue passed to do something specific. Are you it can be dropped? or it makes more sense to simply change the value to INT_MAX?
> 
> You're probably right. I just found a similar check in libosmocore's timer.c. But the key difference is that libosmocore's version of update_nearest() accepts 'struct timeval *', while we accept a signed integer in OsmoPCU.

Ok, found some more details: this function was actually repurposed to deal with TDMA frame numbers, which are represented as signed integers (do not ask me why). In other words, OsmoPCU's update_nearest() never deals with timers, so getting LONG_MAX is impossible.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17006
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9934e05aa050bf93b3c795376f5dca3a848a7e11
Gerrit-Change-Number: 17006
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Jan 2020 18:17:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200125/0341c4c6/attachment.htm>


More information about the gerrit-log mailing list