Change in osmo-pcu[master]: csn1: fix this statement may fall through [-Werror=implicit-fallthrou...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jan 25 05:20:49 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17005 )

Change subject: csn1: fix this statement may fall through [-Werror=implicit-fallthrough=] found by gcc7
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17005/1/src/csn1.cpp 
File src/csn1.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17005/1/src/csn1.cpp@1042 
PS1, Line 1042: no break
> Isn't this enough for a compiler to guess that break is omitted intentionally?
Ok, I figured out why: they build Wireshark with -Wextra. This gives a lot of warnings, but some of them may be very helpful.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17005
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibaf47d7c4fdff326ac1dccf6fff77e2357e6a2bd
Gerrit-Change-Number: 17005
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 25 Jan 2020 05:20:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200125/20b696fc/attachment.htm>


More information about the gerrit-log mailing list